On Sat, Jun 30, 2018 at 1:39 AM Nir Soffer <[email protected]> wrote: > The optimization to start the transfer on the local host makes sense > only when using the rhv-direct=true option. When using a proxy, let the > engine choose a host. >
This avoids the issues with running on host from another dc[1] or host in maintenance mode[2] when not using rh-direct=true. So I think this worth a backport. [1] https://bugzilla.redhat.com/1596810 [2] https://bugzilla.redhat.com/1596851 > --- > v2v/rhv-upload-plugin.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py > index 8805e3552..1404ed1f5 100644 > --- a/v2v/rhv-upload-plugin.py > +++ b/v2v/rhv-upload-plugin.py > @@ -143,8 +143,8 @@ def open(readonly): > # Get a reference to the transfer service. > transfers_service = system_service.image_transfers_service() > > - # Create a new image transfer. > - host = find_host(connection) > + # Create a new image transfer, using the local host is possible. > + host = find_host(connection) if params['rhv_direct'] else None > transfer = transfers_service.add( > types.ImageTransfer( > disk = types.Disk(id = disk.id), > -- > 2.17.1 >
_______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
