On Tue, Jan 22, 2019 at 03:04:07PM -0600, Eric Blake wrote: > ...this code, which returns the wrong error message (partition 3 is not > logical, but the real problem is that there is no partition 3 in the > master table, not that there is no extended partition).
Ugh yes, that was all wrong. [...] > It's also a bit awkward that we don't detect the invalid partition > number until a client first connects - I don't know if that can be > improved to detect it earlier before even allowing clients, especially > if we are going to hand up on the client before even giving them the > magic number. (I also don't know if the "Bad message" claim from the > nbd plugin is worth improving, but that's unrelated to this series). I think this would require some rather deeper changes to the way filters work. > > + type-guid=A2A0D0EB-E5B9-3344-87C0-68B6B72699C7 \ > > Does type-guid even work with mbr? No, this is an error -- in existing code. I'll add an extra patch in v3 to catch this. Thanks, Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
