On 4/24/19 6:26 AM, Richard W.M. Jones wrote: >> But since then, we've fixed the truncate filter to allocate a second >> extents bounded by the truncation size to hand to next_ops->extents, so >> even if the plugin calls nbdkit_add_extent with information beyond the >> length that the truncation filter cares about, the result is still >> bounded to the truncation's choice of end offset. So I think we have >> indeed fixed the initial problem. > > I moved the clamp as originally suggested in your email here: > > https://www.redhat.com/archives/libguestfs/2019-March/msg00126.html > > The output from the commands above is the same and the tests pass. > Patch is below. > > Rich. > >>From a2b7ce7538742fa703d06d78b4159f0705775256 Mon Sep 17 00:00:00 2001 > From: "Richard W.M. Jones" <[email protected]> > Date: Wed, 24 Apr 2019 12:24:07 +0100 > Subject: [PATCH] common/sparse: Return the maximum amount of information about > sparseness. > > By moving the clamp we can return more information about sparseness > that we have but which was not requested. This is permitted and can > improve the efficiency of clients. > > See: https://www.redhat.com/archives/libguestfs/2019-April/msg00192.html
LGTM. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
