On Friday, 3 April 2020 13:50:09 CEST Richard W.M. Jones wrote:
> We actually document that --if-newer can only be used in build mode.
> It sort of makes no sense in prepare mode.  So shouldn't this just
> give an error (either here, or earlier) if we're in prepare mode?

Should we error out, or simply ignore it like done for other options
specific to a certain mode (eg --host-cpu)?

Your note also made me discover a bug related to that option:

  (on Fedora)
  $ touch filesystem
  $ supermin --prepare -o foo --if-newer -v filesystem
  supermin: version: 5.2.0
  supermin: rpm: detected RPM version 4.15
  supermin: rpm: detected RPM architecture x86_64
  supermin: package handler: fedora/rpm
  supermin: prepare: filesystem
  [etc..]
  $ supermin --prepare -o foo --if-newer -v filesystem
  supermin: version: 5.2.0
  supermin: rpm: detected RPM version 4.15
  supermin: rpm: detected RPM architecture x86_64
  supermin: package handler: fedora/rpm
  supermin: if-newer: output does not need rebuilding

-- 
Pino Toscano

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs

Reply via email to