On Monday, 1 June 2020 18:43:36 CEST Richard W.M. Jones wrote: > Part 2 fix for: > https://bugzilla.redhat.com/show_bug.cgi?id=1842440 > > Actually this fix on its own should be sufficient, but probably we > want the nbdkit fixes too. > > Note this uses actual OCaml 4.05 features! ("let open" and the > Unix.tcgetattr functions).
BTW Unix.tcgetattr is very old, even old 3.11 had it (found in some old tests of mine). LGTM; IMHO printing user/host in the password prompt would make it more clear as to for which host the password is asked. -- Pino Toscano
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
