On 8/18/20 5:50 AM, Richard W.M. Jones wrote:
This is #defined as empty at the moment, but it allows the Windows
port to define this __declspec(dllexport), which is necessary for
symbols to be exported in DLLs.
---
  include/nbdkit-common.h | 86 ++++++++++++++++++++++++-----------------
  include/nbdkit-filter.h | 42 +++++++++++++-------
  include/nbdkit-plugin.h |  6 +--
  server/main.c           |  2 +
  4 files changed, 83 insertions(+), 53 deletions(-)

ACK.


+extern NBDKIT_DLLEXPORT int nbdkit_parse_unsigned (const char *what,
+                                                   const char *str,
+                                                   unsigned *r);

This leads to some awkward-looking hanging. Should we reformat differently, similar to:

extern NBDKIT_DLLEXPORT int
nbdkit_parse_unsigned (const char *what, const char *str,
                       unsigned *r);

?


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

_______________________________________________
Libguestfs mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libguestfs

Reply via email to