On Wed, Nov 11, 2020 at 12:52:31PM +0100, Pino Toscano wrote: > On Wednesday, 23 September 2020 17:57:47 CET Pino Toscano wrote: > > Continuation/rework of: > > https://www.redhat.com/archives/libguestfs/2020-May/msg00020.html > > > > This is my approach, as I explained here: > > https://bugzilla.redhat.com/show_bug.cgi?id=1828952#c4 > > https://www.redhat.com/archives/libguestfs/2020-May/msg00035.html > > IOW: do not attempt to relabel if the guest is not enforcing, as it is > > either useless or may fail; few words more are in the comments of patch > > #3. > > Are there any non-ideological actual technical objection to this patch > series? > > If not, I'll push it in a week.
Yes, I have technical objections. I do not have any "ideological" objections to it. Please do not push the patch as is. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/ _______________________________________________ Libguestfs mailing list [email protected] https://www.redhat.com/mailman/listinfo/libguestfs
