On Mon, Nov 08, 2021 at 09:55:56PM +0200, Nir Soffer wrote:
> On Mon, Nov 8, 2021 at 9:46 PM Eric Blake <[email protected]> wrote:
> >
> > On Sun, Nov 07, 2021 at 06:35:50PM +0200, Nir Soffer wrote:
> > > Add make-dist.sh script, creating a distribution tree for a proxy
> > > server[1]. The created tree must be served by the web server serving the
> > > libnbd module, for example:
> > >
> > >     https://download.libguestfs.org/libnbd-golang
> > >
> > ...
> > > +echo "{\"Version\": \"$version\"}" > $module_dir/@latest
> > > +echo "{\"Version\": \"$version\"}" > $v_dir/$version.info
> > > +
> > > +# This is not entirely corect. This file should have a list of all
> >
> > correct
> >
> > > +# version avaialable, here we create only single version. This should
> >
> > versions available
> 
> This is already pushed with the errors, but it is removed by:
> https://listman.redhat.com/archives/libguestfs/2021-November/msg00084.html

I fixed these when I pushed it, although I forgot about the incorrect
URI in the commit message.  Oh well ...

Rich.

> > > +# really be done on the server by appending the new version to the list
> > > +# file.
> > > +echo $version > $v_dir/list
> >
> > Would using >> instead of > work, or would it risk creating a list
> > that has too many (potentially duplicate) entries?
> 
> Yes >> is the right way, but this cannot work in build time. If must
> done on the server so it will include all the version published by
> the server.
> 
> In general old versions should never be deleted from the server, in
> case someone pinned a project to a specific version.
> 
> Looking in https://download.libguestfs.org/libnbd/, I don't think we
> have any issue with keeping all published versions.
> 
> Nir

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW

_______________________________________________
Libguestfs mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/libguestfs

Reply via email to