On Thu, Jan 06, 2022 at 03:09:06PM +0100, Laszlo Ersek wrote:
> Let CNV / KubeVirt know about the "gcaps_virtio_1_0" field as well, so
> that it can make the same determination from "machine" and
> "gcaps_virtio_1_0" as virt-v2v does in the libvirt output (from an earlier
> patch in this series).
> 
> Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1942325
> Signed-off-by: Laszlo Ersek <[email protected]>
> ---
> 
> Notes:
>     This patch changes the JSON output as follows:
>     
>     > @@ -45,7 +45,8 @@
>     >          "virtio-balloon": true,
>     >          "isa-pvpanic": false,
>     >          "virtio-socket": false,
>     > -        "acpi": true
>     > +        "acpi": true,
>     > +        "virtio-1-0": true
>     >      },
>     >      "sound": {
>     >          "model": "ich6"
> 
>  output/create_json.ml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/output/create_json.ml b/output/create_json.ml
> index b48902b7d221..985e10a931c8 100644
> --- a/output/create_json.ml
> +++ b/output/create_json.ml
> @@ -219,6 +219,7 @@ let create_json_metadata source inspect
>        "isa-pvpanic", JSON.Bool guestcaps.gcaps_isa_pvpanic;
>        "virtio-socket", JSON.Bool guestcaps.gcaps_virtio_socket;
>        "acpi", JSON.Bool guestcaps.gcaps_acpi;
> +      "virtio-1-0", JSON.Bool guestcaps.gcaps_virtio_1_0;
>      ] in
>    List.push_back doc ("guestcaps", JSON.Dict guestcaps_dict);

Patches 1-5 are straightforward, so:

ACK up to here.

I'll need to concentrate harder on the next few which
involve C bindings ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

_______________________________________________
Libguestfs mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/libguestfs

Reply via email to