On Fri, Feb 11, 2022 at 03:21:21AM +0200, Nir Soffer wrote: > Add unit tests and benchmarks for AioBuffer. The tests are trivial but > they server as running documentation, and they point out important > details about the type. > > The benchmarks show the efficiency of allocating a new buffer, zeroing > it, and interfacing with Go code. > > These tests will also ensure that we don't break anything by the next > changes. > > To run the benchmarks use: > > $ go test -run=xxx -bench=. [...] > +# Run the benchmarks with 10 milliseconds timeout to make sure they do > +# not break by mistake, without overloading the CI. For performance > +# testing run "go test" directly. > +$GOLANG test -run=XXX -bench=. -benchtime=10ms
-run param is a regexp matching the names of the tests to run. It might be best to use something like this instead: go test -run=<regexp> -bench=. because elsewhere we use "XXX" to mark code that needs to be fixed. Apart from this the whole series seems fine to me, ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs