v2 was here: https://listman.redhat.com/archives/libguestfs/2022-August/029726.html
Since then, I've addressed even more bug fixes, improved comments and commit messages to better explain the changes along the way, added a couple more APIs (nbd_opt_list_meta_context_queries, nbd_opt_structured_reply), and improved some unit tests. A lot of this work is thanks to Laszlo's careful reviews. I still want to add nbd_opt_starttls, but this series has already grown big enough that it is worth getting more of it committed. Eric Blake (18): api: Fix crashes on nbd_connect_command with bad argv tests: Add coverage of unusual nbd_connect_command argv api: Allow nbd_opt_list_meta_context() without SR tests: Test nbd_opt_list_meta_context() without SR api: Localize list used during NBD_OPT_*_META_CONTEXT api: Add nbd_[aio_]opt_list_meta_context_queries tests: Language port of nbd_opt_list_meta_context_queries() api: Add nbd_set_request_meta_context() tests: Language port of nbd_set_request_meta_context() tests info: Explicitly skip NBD_OPT_SET_META_CONTEXT in --list mode api: Make nbd_opt_list_meta_context stateless tests: Add coverage for stateless nbd_opt_list_meta_context api: Reset state on changed nbd_set_export_name() tests: Add coverage for nbd_set_export_name fix api: Add nbd_[aio_]opt_set_meta_context[_queries] tests: Language port of nbd_opt_set_meta_context() tests api: Add nbd_[aio_]opt_structured_reply() tests: Language port of nbd_opt_structured_reply() tests lib/internal.h | 6 +- generator/API.ml | 430 +++++++++++++++++- generator/C.ml | 2 +- generator/states-newstyle-opt-go.c | 2 + generator/states-newstyle-opt-meta-context.c | 85 ++-- generator/states-newstyle-opt-starttls.c | 1 + .../states-newstyle-opt-structured-reply.c | 22 +- generator/states-newstyle.c | 4 + lib/connect.c | 10 +- lib/flags.c | 4 +- lib/handle.c | 22 + lib/opt.c | 143 +++++- lib/utils.c | 81 +++- python/t/110-defaults.py | 1 + python/t/120-set-non-defaults.py | 2 + python/t/230-opt-info.py | 36 +- python/t/240-opt-list-meta.py | 61 ++- python/t/245-opt-list-meta-queries.py | 68 +++ python/t/250-opt-set-meta.py | 134 ++++++ python/t/255-opt-set-meta-queries.py | 76 ++++ ocaml/tests/Makefile.am | 3 + ocaml/tests/test_110_defaults.ml | 2 + ocaml/tests/test_120_set_non_defaults.ml | 3 + ocaml/tests/test_230_opt_info.ml | 43 +- ocaml/tests/test_240_opt_list_meta.ml | 73 ++- ocaml/tests/test_245_opt_list_meta_queries.ml | 68 +++ ocaml/tests/test_250_opt_set_meta.ml | 170 +++++++ ocaml/tests/test_255_opt_set_meta_queries.ml | 79 ++++ tests/Makefile.am | 29 ++ tests/errors-connect-null.c | 88 ++++ tests/opt-info.c | 92 +++- tests/opt-list-meta-queries.c | 146 ++++++ tests/opt-list-meta.c | 135 +++++- tests/opt-set-meta-queries.c | 150 ++++++ tests/opt-set-meta.c | 259 +++++++++++ tests/opt-structured-twice.c | 145 ++++++ .gitignore | 5 + golang/Makefile.am | 3 + golang/libnbd_110_defaults_test.go | 8 + golang/libnbd_120_set_non_defaults_test.go | 12 + golang/libnbd_230_opt_info_test.go | 111 ++++- golang/libnbd_240_opt_list_meta_test.go | 176 ++++++- .../libnbd_245_opt_list_meta_queries_test.go | 115 +++++ golang/libnbd_250_opt_set_meta_test.go | 307 +++++++++++++ .../libnbd_255_opt_set_meta_queries_test.go | 141 ++++++ info/list.c | 3 +- info/show.c | 3 +- 47 files changed, 3405 insertions(+), 154 deletions(-) create mode 100644 python/t/245-opt-list-meta-queries.py create mode 100644 python/t/250-opt-set-meta.py create mode 100644 python/t/255-opt-set-meta-queries.py create mode 100644 ocaml/tests/test_245_opt_list_meta_queries.ml create mode 100644 ocaml/tests/test_250_opt_set_meta.ml create mode 100644 ocaml/tests/test_255_opt_set_meta_queries.ml create mode 100644 tests/errors-connect-null.c create mode 100644 tests/opt-list-meta-queries.c create mode 100644 tests/opt-set-meta-queries.c create mode 100644 tests/opt-set-meta.c create mode 100644 tests/opt-structured-twice.c create mode 100644 golang/libnbd_245_opt_list_meta_queries_test.go create mode 100644 golang/libnbd_250_opt_set_meta_test.go create mode 100644 golang/libnbd_255_opt_set_meta_queries_test.go -- 2.37.3 _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
