On 09/26/22 13:59, Richard W.M. Jones wrote: > > Apart from Dan's suggestions in patch 1, the series looks good to me. > > FWIW RHEL 7 (the earliest distro with PCRE 2) has glib2 2.56.1 & > gtk3 3.22.30, so supporting any earlier versions also seems pointless, > so that might be another thing to review. We could make USE_POPOVERS > unconditional, and make gui-gtk3-compat.h considerably less > complicated.
I guess I could do this, but I don't feel comfortable about it with the many other distro families we supposedly support. :/ We don't have such CI, and build-testing manually is horribly inefficient (cue the situation with GTK3 -- I've not built p2v with GTK3 thus far even on Fedora). Debian at least has a package directory on the web, but I've always had trouble with the other non-Fedora-like distros. (And even regarding Debian, I don't know what major release we aim at.) Honestly it doesn't feel like we're making a strong promise in "dependencies.m4" to these other distros, given that we almost never build or test on those distros. On the other hand it seriously complicates things for development. Laszlo _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
