On Mon, Jan 30, 2023 at 03:22:26PM +0100, Laszlo Ersek wrote:
> + str = gtk_entry_get_text (GTK_ENTRY (oo_entry));
> + guestfs_int_free_string_list (config->output.misc);
> + config->output.misc = guestfs_int_split_string (',', str);
My concern here is that someone is going to put "foo=bar, baz=1" in
this field, and it will improperly split above. So maybe a bit of
trimming on the resulting array?
> + if (config->output.misc == NULL)
> + error (EXIT_FAILURE, errno, "strdup");
> +
> /* Display the UI for conversion. */
> show_running_dialog ();
>
> diff --git a/virt-p2v.pod b/virt-p2v.pod
> index ecdae46eaaf6..a7e8edcbf9f0 100644
> --- a/virt-p2v.pod
> +++ b/virt-p2v.pod
> @@ -175,6 +175,8 @@ first-time virt-p2v user.
> │
> │ Output allocation (-oa): [sparse ▼]
> │
> + │ Misc. options (-oo): [___________________]
> + │
>
> All output options and paths are relative to the conversion server
> (I<not> to the physical server).
Be kind of nice to add a tiny bit more documentation here, especially
as there's only a tool tip telling you what the field should contain.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
_______________________________________________
Libguestfs mailing list
Libguestfs@redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs
