On Mon, Jun 12, 2023 at 07:27:51PM +0100, Richard W.M. Jones wrote: > These patches aren't related to each other, but both are quite simple. > > The second one requires particular attention - it's my experience that > printing out the state transitions in debug mode has never helped me > to diagnose a bug, but it has made the debug logs huge and hard to > follow. However that might just be me! Has it helped anyone else? > Also I'm open to the concept of debug levels (LIBNBD_DEBUG=2 etc)
When adding a state, I've found it mildly helpful; but that's not the common scenario. I agree that it is too verbose for normal usage. It's easy enough to revert this patch, or to amend the patch to output #if 0 or some other witness macro to compile with CFLAGS=-DLIBNBD_STATE_VERBOSE=1, or similar, if we think making this easy to re-enable is important. Otherwise, I'm fine with cutting it out. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
