On Mon, Aug 14, 2023 at 08:31:51AM +0000, Tage Johansson wrote: ... > > None of these touched top-level README.md, which should now list cargo > > and any other new optional build dependencies that must be installed > > for enabling Rust bindings. > > > True, I'll add that in an upcoming patch. > > > An unrelated question: Should the patch which adds cargo as an optional > build dependency to README be a reply to this message or should I send it as > a new thread? I'll send it as a new thread now, but what is the best way to > do it?
For a quick patch that can be applied out-of-order, a separate thread is probably easiest. At some point, it boils down to a judgment call on what's easier for the person writing the code (the notion of rebasing and maintaining parallel patches is not trivial for a new coder) as well as those reviewing and applying the code (tracking multiple threads may make it easier to apply quick patches, but also means more threads to track in the long run). At any rate, I see that thread already landed, so in the end you chose well on this case. -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org _______________________________________________ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs
