> There was one spot you missed that should have been converted to > subdomain_id, and one spot you converted that shouldn't have been > (although I'm not surprised, it was in a subdomain-handling function > and tricked me too before I ran a class object test through it).
Roy, just curious as to which source file this was happening. It is much easier for me to make the change in to my source directly rather than updating and merging the code along with my existing changes. > I left the typedef as unsigned char for now; if you and Ben want to > change the default to unsigned int that's fine with me. I guess asking to make this configurable with ./configure might be too much to ask. But is there some way to define a flag or something to make this change with a user defined header. Perhaps something with preprocessors (#ifdefs) ? Or does it not make sense ? I propose this because if tomorrow you change some other property in Elem and typedef it, I would like it to be easy enough to change the definition to fit my needs. If there is no clean way to do this, do not worry about it. As long future changes are typedef'd also, I can modify it accordingly. Vijay On Wed, Feb 11, 2009 at 6:02 PM, Roy Stogner <royst...@ices.utexas.edu> wrote: > > On Wed, 11 Feb 2009, Roy Stogner wrote: > >> On Wed, 11 Feb 2009, Vijay S. Mahadevan wrote: >> >>> Do have a look at the patch and if everything looks good (conventions >>> and definition placement), do commit this. >> >> Looks good so far; let me test a couple things and I'll commit it. > > There was one spot you missed that should have been converted to > subdomain_id, and one spot you converted that shouldn't have been > (although I'm not surprised, it was in a subdomain-handling function > and tricked me too before I ran a class object test through it). I > also got rid of some of those static casts where a copy will do just > as well, just for aesthetics' sake. > > I also moved the typedef to a new header file, to allow mesh_tools.h > to continue to get away with forward declaring Elem. > > I left the typedef as unsigned char for now; if you and Ben want to > change the default to unsigned int that's fine with me. > > It's all committed to SVN now. > --- > Roy > ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Libmesh-devel mailing list Libmesh-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libmesh-devel
