Roy, no offense taken. Its just a name.. If there are valid
criticisms, I always welcome it and if not, I do not bother with it
much.
> I'm not just guessing or deducing this behavior; this is how my code
> works, and it doesn't throw errors in EquationSystems::read().
I know. This was the behavior I noticed for a long time. When I made
my changes to add my new System class, I originally did not change the
system_type. But later when I did, my restart files did not work any
more. And I read the code for EquationSystems, System and XDR before
making the changes I did. This was not a whimsical move because it was
the easiest. This was what made perfect sense back then. Now that its
been more than 8 months since I made this change, I cannot remember
all the reasons for it...
> We'll leave it in the SVN head. It's a trivial overhead, and even if
> there's a better solution for your problem, it might be useful for
> other reasons we haven't thought of yet.
Thanks. I have bunch of custom changes in my working copy and am just
trying to eliminate them in order to make my merges easy. If any of
this does not make sense, do not worry about it. You could always say
NO because these are just suggestions so that at some point in the
future, I can probably converge my version with the trunk while making
appropriate changes in my code.
Vijay
On Wed, Jan 13, 2010 at 4:31 PM, Roy Stogner <royst...@ices.utexas.edu> wrote:
>
> On Wed, 13 Jan 2010, Vijay S. Mahadevan wrote:
>
>> I understand that. Again, I was talking about SpecialSnowFlakeSystem
>> which will fail all the "ifs" and hence throw an error at the end,
>
> Not if you don't override its parent's system_type() method. Then
> the string that gets written out (and so eventually read in) will
> match a libMesh parent class, the add_system<Parent>("name") call will be
> made. Because a system with "name" already exists the add_system()
> call will just do a get_system(), and because Parent is a parent class
> of SpecialSnowflake the dynamic_cast in get_system will still be happy.
>
> I'm not just guessing or deducing this behavior; this is how my code
> works, and it doesn't throw errors in EquationSystems::read().
>
>> even if it has been added by the SnowFlake aware CustomEquationSystem
>> a-priori. SpecialSnowFlakeSystem is the reason why I've been arguing
>> to make add_system(type, name) virtual. If no one else finds this
>> useful, I can make this as my specific change in my working copy.
>
> We'll leave it in the SVN head. It's a trivial overhead, and even if
> there's a better solution for your problem, it might be useful for
> other reasons we haven't thought of yet.
> ---
> Roy
>
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Libmesh-devel mailing list
Libmesh-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libmesh-devel
