Yes, that fix looks good. I guess I only ever used this for generalized eigenvalue problems...
David On 03/25/2013 06:27 PM, Shiyuan Gu wrote: > Hi all, > It looks like there is a bug in CondensedEigenSystem::solve(). In case > of standard (non-generalized) eigenvalue problem, > CondensedEigenSystem::matrix_B is NULL but matrix_B is called without > testing whether it is NULL which cause an invalid memory access. > Adding one line to test generalized() seems to fix the bug. > > Shiyuan Gu > -------------------------- > > diff --git a/libmesh/src/systems/condensed_eigen_system.C > b/libmesh/src/systems/condensed_eigen_syst > index e554a36..fd823ce 100644 > --- a/libmesh/src/systems/condensed_eigen_system.C > +++ b/libmesh/src/systems/condensed_eigen_system.C > @@ -125,7 +125,7 @@ void CondensedEigenSystem::solve() > matrix_A->create_submatrix(*condensed_matrix_A, > local_non_condensed_dofs_vector, > local_non_condensed_dofs_vector); > - > + if( generalized() ) > matrix_B->create_submatrix(*condensed_matrix_B, > local_non_condensed_dofs_vector, > local_non_condensed_dofs_vector); > ------------------------------------------------------------------------------ > Own the Future-Intel® Level Up Game Demo Contest 2013 > Rise to greatness in Intel's independent game demo contest. > Compete for recognition, cash, and the chance to get your game > on Steam. $5K grand prize plus 10 genre and skill prizes. > Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d > _______________________________________________ > Libmesh-users mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/libmesh-users ------------------------------------------------------------------------------ Own the Future-Intel® Level Up Game Demo Contest 2013 Rise to greatness in Intel's independent game demo contest. Compete for recognition, cash, and the chance to get your game on Steam. $5K grand prize plus 10 genre and skill prizes. Submit your demo by 6/6/13. http://p.sf.net/sfu/intel_levelupd2d _______________________________________________ Libmesh-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/libmesh-users
