On 3/19/19 6:10 AM, Fabiano Fidêncio wrote:
Let's adjust the 8.0 regex as it may consist in 8.0.x, which should
always be detected as 8.0.
By doing this adjustment, the unknown regex also has to be adjusted
accordingly.
Signed-off-by: Fabiano Fidêncio <[email protected]>
---
data/os/redhat.com/rhel-8-unknown.xml.in | 16 ++++++++--------
data/os/redhat.com/rhel-8.0.xml.in | 16 ++++++++--------
2 files changed, 16 insertions(+), 16 deletions(-)
Reviewed-by: Cole Robinson <[email protected]>
But for cases like this where it's not immediately obvious what values
we accept, it would be nice to add a comment with a few different
examples we need to match. So 8.X, 8.X.X, etc. One comment per file
should be fine IMO
- Cole
_______________________________________________
Libosinfo mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libosinfo
