On 3/26/19 11:30 AM, Fabiano Fidêncio wrote:
> On Tue, Mar 26, 2019 at 4:26 PM Daniel P. Berrangé <[email protected]> 
> wrote:
>>
>> Older versions of pytest don't have the --log-level arg
>>
>> Signed-off-by: Daniel P. Berrangé <[email protected]>
>> ---
>>  Makefile | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 254b7af..c63cb6e 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -34,6 +34,8 @@ ZANATA = zanata
>>
>>  PYTHON = python3
>>
>> +PYTEST_LOG_LEVEL = $(shell $(PYTHON) -m pytest --help | grep log-level 
>> >/dev/null && echo "--log-level=info")
> 
> This seems the easiest path to take, indeed.
> I'm fine with this but I'd also like to hear from Cole.
> 

ACK from me. As I said on IRC I think switching from log.info to plain
print() is better for other reasons as well but we can discuss that
later. This gets us closer to having working CI so let's push it

Thanks,
Cole

_______________________________________________
Libosinfo mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/libosinfo

Reply via email to