Hey Alex, On Thu, 2009-08-06 at 20:59 -0500, Alex Mauer wrote: > I've found a couple of problems with the Scrobble Free plugin, and so > here's a pair of patches to fix them:
> First, the scrobbler always scrobbles the track, regardless of how much > has been played. This is because the "tick" signal uses nanoseconds for > its elapsed time value, and the elapsed time in nanoseconds is > practically always greater than half the track duration in seconds. Oh, looks like the signal was changed earlier in the year to report nanoseconds. That's kind of annoying, it was working fine with 0.12.0. Moving to elapsed-changed should fix it either way, so it sounds like the best solution. > The second problem is that Scrobble Free uses the player's current > position in the track as the elapsed play time, rather than using the > actual amount of time that the track has been playing. Yep, this was on my todo list to fix. I was planning on simply accumulating elapsed play time in Track.elapsed rather than having to track playing state, it seemed like it might be a bit cleaner. I'll have a look when I have a moment (unless you want to) at this but am pretty happy with your patch otherwise. Thanks for the fixes. I really have to roll a new release soon. /Mike -- ⎊ Michael Gratton. "Mea navis aëricumbens anguillis abundat." ⎈ <http://web.vee.net/>
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Libre-fm mailing list [email protected] http://lists.autonomo.us/mailman/listinfo/libre-fm
