https://bugs.freedesktop.org/show_bug.cgi?id=34836

--- Comment #44 from Michael Meeks <michael.me...@novell.com> ---
> Unfortunately this commit is a huge code import from AOO.

Right - and as such we cannot revert any part of it without causing severe
problems. Of course, we can research the differences that cause this issue and
then re-fix the bug; that is not a problem.

If you have questions on that please contact me by private mail not in this
bug.

This bug looks like it is becoming unmanageable - it seems to include lists of
un-related issues, it's getting hard to read - which hugely decreases the
likelihood that any developer will get to the end and be able to fix this bug.
It is the kind of  bug that can never be 'fixed' because one of the several
sub-branches of the bug will get it re-opened, and everyone ends up
un-satisfied.

EPS is a subset of postscript that LibreOffice cannot render by itself. We
require an external program to convert this to a bitmap - it would be a nice
enhancement to fix that so we had an embedded EPS interpreter - however, that
is a rather significant enhancement request - it needs splitting into a new
bug.

Possibly we have (somehow) mangled and reduced the resolution of the pixel
image we render as a consequence of including Armins' changes in the re-base.
If so, we need to look at the DPI handling around that I imagine - it would be
good to pick one of the duplicates that is clean, and swap the order here -
make this one a duplicate of that bug - and make that bug a MAB for 4.0 - so we
solve it.

Rendering EPS requires pstoedit thus:

static bool RenderAsEMF(const sal_uInt8* pBuf, sal_uInt32 nBytesRead, Graphic
&rGraphic)
{
    TempFile aTemp;
    aTemp.EnableKillingFile();
    OUString fileName("pstoedit" EXESUFFIX);
    OUString arg1("-f");
    OUString arg2("emf:-OO");
    OUString arg3("-");
    OUString output;
    osl::FileBase::getSystemPathFromFileURL(aTemp.GetName(), output);
    rtl_uString *args[] =
    {
        arg1.pData, arg2.pData, arg3.pData, output.pData
    };


If the program is not in your path - it will not be found. We could of course
try to add a series of paths to try in this eventuality but that should be a
separate issue. Again.

Can I have help from a QA guy to close this issue, spawn several others and get
the problems split up nicely !? :-)

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to