https://bugs.documentfoundation.org/show_bug.cgi?id=85094
Julien Nabet <serval2...@yahoo.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |serval2...@yahoo.fr
--- Comment #18 from Julien Nabet <serval2...@yahoo.fr> ---
Just for the record, if I use this patch to revert print part in old Armin's
patch:
diff --git a/vcl/source/gdi/print.cxx b/vcl/source/gdi/print.cxx
index 06625a4227bd..dbdf8c9bafe2 100644
--- a/vcl/source/gdi/print.cxx
+++ b/vcl/source/gdi/print.cxx
@@ -1307,23 +1307,10 @@ bool Printer::SetPaperSizeUser( const Size& rSize )
const Size aPixSize = LogicToPixel( rSize );
const Size aPageSize = PixelToLogic(aPixSize,
MapMode(MapUnit::Map100thMM));
- bool bNeedToChange(maJobSetup.ImplGetConstData().GetPaperWidth() !=
aPageSize.Width() ||
- maJobSetup.ImplGetConstData().GetPaperHeight() != aPageSize.Height());
-
- if(!bNeedToChange)
- {
- // #i122984# only need to change when Paper is different from
PAPER_USER and
- // the mapped Paper which will created below in the call to
ImplFindPaperFormatForUserSize
- // and will replace maJobSetup.ImplGetConstData()->GetPaperFormat().
This leads to
- // unnecessary JobSetups, e.g. when printing a multi-page fax, but
also with
- // normal print
- const Paper aPaper = ImplGetPaperFormat(aPageSize.Width(),
aPageSize.Height());
-
- bNeedToChange = maJobSetup.ImplGetConstData().GetPaperFormat() !=
PAPER_USER &&
- maJobSetup.ImplGetConstData().GetPaperFormat() != aPaper;
- }
-
- if(bNeedToChange)
+ if ( (maJobSetup.ImplGetConstData().GetPaperFormat() != PAPER_USER) ||
+ (maJobSetup.ImplGetConstData().GetPaperWidth() != aPageSize.Width())
||
+ (maJobSetup.ImplGetConstData().GetPaperHeight() !=
aPageSize.Height())
+ )
{
JobSetup aJobSetup = maJobSetup;
ImplJobSetup& rData = aJobSetup.ImplGetData();
preview in print dialog works well (first page in portrait, second in
landscape, third in portrait)
Also we've been using libtiff since 2022-05 so perhaps the whole patch is
obsolete.
"itiff.cxx" is now in vcl/source/filter/itiff and only contains 360 lines
"ccidecom.hxx" and "ccidecom.cxx" don't exist anymore in LO codebase.
To be sure, we'd need someone who has a fax and able to test a build with the
above patch, not simple I suppose...
--
You are receiving this mail because:
You are the assignee for the bug.
