https://bugs.documentfoundation.org/show_bug.cgi?id=160635

Stéphane Guillou (stragu) <stephane.guil...@libreoffice.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |bibisected, bisected
             Status|NEEDINFO                    |NEW
            Version|24.2.2.2 release            |7.5.3.2 release
                 CC|                            |caolan.mcnamara@collabora.c
                   |                            |om
             Blocks|                            |47148, 126152
            Summary|"Image Filter not found"    |open or insert a TIFF image
                   |error when trying to open a |over 33,554,432 pixels
                   |multipage TIFF image        |fails in various ways
                   |                            |("Image Filter not found"
                   |                            |in sd, Section dialog in
                   |                            |sw, Push button in sc)

--- Comment #5 from Stéphane Guillou (stragu) 
<stephane.guil...@libreoffice.org> ---
Using ImageMagick, I can insert a 201.3 mb image created with:

convert -size 5792x5793 xc:pink pink.tif

But it fails with a 201.4 mb image created with:

convert -size 5793x5793 xc:pink pink.tif

So it looks like there's a number of pixels over which the filter fails.
No issue if image is e.g. a PNG of the same size.
Issue is not related to the size of the file, see bug 160635 in which it fails
for a 109 mb picture.

Funnily enough, if it fails to insert it into a Calc document, you end up with
a Push Button Form Control labelled with the path to the image, and in Writer,
with the section dialog.

Reproduced in recent own build:

Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6f4adc1274cfac30b9097411bb193bd4386969f0
CPU threads: 8; OS: Linux 6.5; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: CL threaded

As well as LO 7.5.9, but not in 7.4.0.3.

Bibisected with linux-64-7.5 to first bad build
[1ae6bd31aa05c337c00ab8c83f7fdf35ed0c6fe4] which is
a5d5c29769d3c744d8a89052842f73dabd71f445, a cherrypick of:

commit  b05fb34d48da717447b9b86db9546df72b25e988
author  Caolán McNamara         Sat Apr 01 22:04:32 2023 +0100
committer       Caolán McNamara Sun Apr 02 17:44:42 2023 +0200
use the same max size that libtiff defaults to for its own utilities
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149922

Indeed, the patch defines:

nMaxPixelsAllowed = (256 * 1024 * 1024) / 4

... which is later divided by 2, so a max of 33,554,432 pixels, which matches
the 5793x5793 import failing.

So that was by design, but I guess we could fail more gracefully. What do you
think, Caolán?


Referenced Bugs:

https://bugs.documentfoundation.org/show_bug.cgi?id=47148
[Bug 47148] [META] Image handling problems
https://bugs.documentfoundation.org/show_bug.cgi?id=126152
[Bug 126152] [META] TIFF image bugs and enhancements
-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to