https://bugs.documentfoundation.org/show_bug.cgi?id=150834

--- Comment #4 from Mike Kaganski <[email protected]> ---
(In reply to Aron Budea from comment #3)
> Mike, is this a step back compared to bug 98896's fix, and should this bug
> and bug 137666 be fixed in a different way?

No, it is not a step back (at least in this context). Commit
dd199ccb46c036713c704a23e137d04623936e47 didn't decrease the dimensions of the
rectangle - it has kept the first part of code functionally unchanged (because
aRect.getWidth()+1 is the same as aRect.GetWidth()), and increased dimensions
in the second part (for the same reason).

The change that you quote must be a hack. There is no way this could be "the
correct thing"; it is not even "inclusive" rectangle concept, this is
"inclusive plus one". I anticipate some problems with multi-monitor setup -
like partially protruding to the other monitor with this ... but it is not
harmful in the frame of this bug.

Of course, having the change documented in commit message (or in a comment in
the code) would be ideal...

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to