https://bugs.freedesktop.org/show_bug.cgi?id=65975
Michael Meeks <michael.me...@novell.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
CC| |fridrich.st...@bluewin.ch,
| |mst...@redhat.com,
| |tima...@gmail.com
Blocks| |60270
--- Comment #3 from Michael Meeks <michael.me...@novell.com> ---
The gerrit thread had.
Andras Timar Jun 20 5:55 PM
Patch Set 1: This need some tweaks before it is merged
Your patch fixes your build but breaks the "logic". With this patch 64-bit
shell extensions will not work for users who do not have the 64-bit VC2010
Runtime installed. I'll prepare a better patch soon.
Michael Stahl Jun 20 6:55 PM
Patch Set 1: This need some tweaks before it is merged
Andras is right: the 64bit dlls are copied to solver/bin so that the installer
finds them since they are packaged as files, while the 32bit ones are in some
mystery MSM thingy and (apparently) don't need to be in solver.
confusingly the same find_msvc_x64_dlls function also finds debug dlls (for the
build CPU architecture, not necessarily 64bit), which should not be in the
installation set; i'm not sure if it's actually necessary to copy these to
solver/bin nowadays (AFAIR it was needed for MSVC 2008 but they should actually
be installed on the system by MSVC).
so clearly there's some need for cleanup here.
But Fridrich merged it anyway to 4.1. So I'll close this.
The reality is that the -4-1 and master branches are un-buildable without this,
and the build fails in a silent and extremely ugly fashion.
Personally I'd prefer to have something buildable that misses out on some
obscure feature - but ...
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
