https://bugs.freedesktop.org/show_bug.cgi?id=66025
--- Comment #37 from Stephan Bergmann <sberg...@redhat.com> --- (In reply to comment #36) > Created attachment 82905 [details] [review] > Patch correction > > Hmm, this is embarrassing. In seeing the patch committed, I suddenly > realized I left one bit of test code in it, in the first exception handler > (which has no need to assign the exception to 'e'). This patch just removes > that small bit of code, and applies on top of the prior patch. > > The original patch technically works fine as-is, and I considered not even > bothering with a fix, but some future reviewer may wonder about any > relationship between that variable and the final exception (there isn't any) > due to their naming, so it feels worth cleaning up. > > My apologies. I don't know how I missed it originally. No problem at all, will push that additional patch in an instant. (In the future, it would be extra helpful if you could produce patches with "git format-patch", which are directly applicable via "git am", or even push them directly to LO's gerrit, see <https://wiki.documentfoundation.org/Development/gerrit>.) Funnily enough, I had wondered about that spurious "as e" when looking at the patch, but decided that it is harmless enough and/or my non-existent Python knowledge plays tricks on me. Another thing that made me wonder is: I assume that _uno_import will never be called by multiple threads in parallel, anyway, or else the "d[x] = unknown" and "del d[x]" might introduce a new race there. -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
