[Bug 170740] LibreOffice crashing when tiling with option key and drag on MacOS

[bugzilla-daemon]

https://bugs.documentfoundation.org/show_bug.cgi?id=170740

--- Comment #21 from d...@libreoffice.org <d...@libreoffice.org> ---
(In reply to Patrick (volunteer) from comment #20)
> (In reply to Patrick (volunteer) from comment #19)
> > https://bugs.documentfoundation.org/show_bug.cgi?id=170740
> 
> Oops. Wrong link. Here is the link to the patch in comment #19:
> 
> https://gerrit.libreoffice.org/c/core/+/200957

I think the patch is just doing pointer comparison on the NSEvents? In my case
there are two NSEvent pointers getting alternately returned, though they both
contain exactly the same data. So I did this:

static bool sameNSEvent( NSEvent *pFirst, NSEvent *pSecond )
{
    return ([pFirst type] == NSEventTypeLeftMouseUp &&
        [pSecond type] == NSEventTypeLeftMouseUp &&
        [pFirst modifierFlags] == [pSecond modifierFlags] &&
        [pFirst timestamp] == [pSecond timestamp] &&
        [pFirst window] == [pSecond window] &&
        [pFirst windowNumber] == [pSecond windowNumber] &&
        [pFirst clickCount] == [pSecond clickCount] &&
        [pFirst buttonNumber] == [pSecond buttonNumber] &&
        [pFirst eventNumber] == [pSecond eventNumber] &&
        [pFirst pressure] == [pSecond pressure] &&
        NSEqualPoints([pFirst locationInWindow], [pSecond locationInWindow]));

}

But even then there's some oddity with window live resize after snapping; I'll
try to characterize it better tomorrow (Friday).

-- 
You are receiving this mail because:
You are the assignee for the bug.