https://bugs.documentfoundation.org/show_bug.cgi?id=128419
Justin L <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|6.3.2.2 release |5.2 all versions Assignee|[email protected] |[email protected] |desktop.org | Status|NEW |ASSIGNED OS|Linux (All) |All CC| |[email protected] --- Comment #5 from Justin L <[email protected]> --- (In reply to Alex from comment #0) > Steps to Reproduce: > 4. Click 'Find All' --> 'Replace backwards' gets unchecked repro 26.8 > Second example: > 5. Click 'Find Previous' --> 'Replace backwards' gets unchecked repro > Third example: > 6. Click 'Find Previous' or 'Find Next' --> 'Replace backwards' gets checked repro The problem is that the checkbox state is based on m_bReplaceBackwards - re-evaluated whenever StateChangedAtToolBoxControl (which happens after each change in command). But clicking on the 'Replace backwards' checkbox does NOT set this variable. Only pressing 'Replace' sets this variable. - example 1 steps doesn't include pressing "Replace" - example 2 steps don't include pressing "Replace" - example 3 steps don't include pressing "Replace" after the second CB change. This started in 5.2.0 with commit beeef93480fae65840646e4e36aa888efe92579a Author: Akshay Deep on Mon Apr 4 08:51:17 2016 +0000 tdf#98417, tdf#98539: DIALOG: Improvements to the Find & Replace dialog. Added Find Previous Button. Reviewed-on: https://gerrit.libreoffice.org/23057 So things get kinda messy here, because: -we want to save and restore options - like 'replace backwards' -prior to 2016, 'backwards' affected both replace and find -so 'search options' is affect by both the checkbox and 'Find Previous' -Init_Impl is called every StateChangedAtToolBoxControl -tracking whether the checkbox was modified is reset every CommandHdl_Impl. -- You are receiving this mail because: You are the assignee for the bug.
