https://bugs.documentfoundation.org/show_bug.cgi?id=135538

Justin L <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=60
                   |                            |259

--- Comment #19 from Justin L <[email protected]> ---
Bug 60259's LO 4.0 changes are highly relevant here.

Writer findtxt.cxx's DoSearch never searches empty paragraphs.
    while ( ... && nStart < nStringEnd)

DoSearch never accepts bZeroMatch as bFound. However, it does invoke specific
logic to handle a few cases involving $. Thus it really doesn't matter to
Writer if TextSearch::RESrchFrwrd starts accepting all kinds of zero-length
matches. It will just return 'false' regardless.

AFAICS, the only other module (besides Calc) that accepts regex is the macro
editor, with vcl/source/edit. TextView::Replace only replaces when
GetSelection().HasRange() - or when ReplaceAll. This module is pretty basic. It
already doesn't do anything nice with '$' (It doesn't find backwards, and it
gets stuck at the first end searching forwards.) So I don't see any issue with
always matching zero-width regex in UNO/VCL.

Draw/Impress do not accept REGEX searches.

Calc does accept regex. It nicely always steps to the next row before starting
a search, so it doesn't get stuck by zero-length matches. It also isn't too
concerned about the exact position - it reports 'cells' that match, not
fragments of text. 

So I'm not seeing any downsides to accepting whatever lcl_findRegex reports as
'found'.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to