https://bugs.documentfoundation.org/show_bug.cgi?id=174547

            Bug ID: 174547
           Summary: Macro Organizer: Edit button not enabled after
                    creating new dialog
           Product: LibreOffice
           Version: 6.4.0.3 release
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Keywords: bibisected, bisected, regression
          Severity: normal
          Priority: medium
         Component: UI
          Assignee: [email protected]
          Reporter: [email protected]
                CC: [email protected]

1. Open an app, like Writer
2. Go to Tools - Macros - Organize Dialogs, and then click New
3. OK to create new dialog

Observe that the Edit button is disabled. Focus to some other item in the
treeview and then back to your new dialog and Edit is enabled.

Bibisected with linux-64-6.4 to dbe5388c92d988c106cb8def839d031008a0d642
need notify guard around SetCurEntry

There was a small fix for a similar issue in
eee6ef53ebc5756a974e985925550dcd990876ca
Resolves: tdf#128900 can't edit initial macro with empty user profile

Michael: you refactored this code in 234258bc89ea6b375c2a50e088711a69ba3d921b
tdf#130857 weld: Move signal blocking to TreeView::set_cursor

>From code reading in basctl/source/basicide/moduldlg.cxx interesting things are

IMPL_LINK_NOARG(ObjectPage, BasicBoxHighlightHdl, weld::ItemView&, void) {
CheckButtons(); }

and the ObjectPage::CheckButtons() function.

Setting a breakpoint to CheckButtons() and testing, when we change the item
focus in the treeview, we hit this in vcl/source/app/salvtables.cxx:

IMPL_LINK_NOARG(SalInstanceTreeView, SelectHdl, SvTreeListBox*, void)
{
    signal_selection_changed();
}

In the definition of signal_selection_changed() in vcl/source/weld/ItemView.cxx
there is an if clause to return, if event notification is disabled, which is
true after Caolán's change in 6.4.

If we want to do a surgical change, I suppose it should happen in
basctl/source/basicide/moduldlg.cxx in ObjectPage::NewDialog() near the end
where we have

m_xBasicBox->set_cursor(*xIter);
m_xBasicBox->select(*xIter);

But maybe you have a bigger picture idea for this. I don't have a clue anyway
:)

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to