https://bugs.freedesktop.org/show_bug.cgi?id=44511

             Bug #: 44511
           Summary: EDITING: AutoText - segfault when delete/rename action
                    applied while group selected.
    Classification: Unclassified
           Product: LibreOffice
           Version: LibO Master
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: Writer
        AssignedTo: libreoffice-bugs@lists.freedesktop.org
        ReportedBy: c...@sowden.org


Created attachment 55193
  --> https://bugs.freedesktop.org/attachment.cgi?id=55193
Patch to fix bug

Summary
-------
In the Edit -> AutoText dialog, if an entry is selected and then a group
selected the delete/rename/etc actions are still shown in the "AutoText" button
menu when they should not be. These actions are only applicable to entries and
if a user attempts to apply these actions while a group is selected the list
box becomes corrupted and leads to a segfault (the code for these actions
assumes the selected entry has a parent in the listbox).

Exists in MASTER and 3.4.4 (Fedora distro build).

Steps to reproduce
------------------
* Edit -> AutoText
* Create a new group (i.e. with the Categories button) and add a new entry
under this group (select some text in the main doc, Edit -> AutoText, enter a
name in the "Name" field, select the newly created group, click AutoText ->
New).
* Select the newly created entry in the list box and then select the group
name.
* Click the AutoText button and the Copy/Replace/Rename/etc actions are
incorrectly shown. 
* For example, click "Rename" and enter a new name.
* The entry is now incorrectly added as a top-level "group" in the list box.
* Keep clicking the different group names for 10 sec -> segfault.

Patch
-----
Attached is a patch that ensures the Copy/Replace/Rename/etc actions are not
shown in the AutoText menu when a group is selected. I believe this is the
correct behaviour and is what happens when you first open the Edit -> AutoText
dialog i.e. before you actually select an entry.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to