https://bugs.freedesktop.org/show_bug.cgi?id=70196
David Bolen <db3l....@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.freedesktop.or
| |g/show_bug.cgi?id=66025
--- Comment #2 from David Bolen <db3l....@gmail.com> ---
I'm hesitant to consider this a bug as this patch was only intended for LO
versions using Python 3, but if Debian or other distributions are still
continuing to build LO 4.1+ UNO modules against Python 2, then yes, it's
certainly an issue. In that case, I'm also not entirely sure this will turn
out to be the only Python 3-ism at this point in the code base.
In terms of background, this commit was to resolve bug 66025, where import
failures under Python 3 from any package once LO's UNO module was loaded
(regardless of whether the import was related to LO or not) had become
extremely difficult to identify the root cause.
Two thoughts - first, as indicated in the Debian bug, removing the
with_traceback method call will be Python 2 compatible - but defeats the fix
under Python 3. So not a good general purpose change, but it could be a local
distribution patch when building a Python 2 UNO module. Though pushing the
issue downstream feels wrong if there are likely to be other distributions
besides Debian building Python 2 versions.
Alternatively, runtime version checking could be added for separate Python 2
and 3 code paths (I don't see a way to have a single path that works well under
Python 3 while simultaneously supporting 2). I can certainly produce a patch,
but while likely modest, I don't currently have an LO build environment to
verify against Python 2. Is there any chance you might be able to assist me
with a quick sanity check of a patch under Python 2? If not, I suppose since
it already fails under Python 2, it's not like I could make it much worse.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
