https://bugs.freedesktop.org/show_bug.cgi?id=44994
Bug #: 44994
Summary: EasyHack: write out tools' FileCopier class ...
Classification: Unclassified
Product: LibreOffice
Version: LibO Master
Platform: Other
OS/Version: All
Status: UNCONFIRMED
Severity: normal
Priority: medium
Component: Libreoffice
AssignedTo: libreoffice-bugs@lists.freedesktop.org
ReportedBy: michael.me...@novell.com
The implementation of the FileCopier causes problems with sal - needing the
system file-handler to be exposed for various statting methods.
It is unclear that we really need the FileCopier class either - it looks like
it is used only internally to the tools/ code and in only one place:
DirEntry::CopyTo.
And then only if:
FSYS_ACTION_COPYFILE == (nActions & FSYS_ACTION_COPYFILE)
And then only on Unix ;-) we should audit to ensure that all CopyTo's only use
FSYS_ACTION_COPYFILE - the best way is prolly to drop the nActions flag
completely, and then do a full re-compile to catch all the call sites.
We should also check and remove this lot:
#define FSYS_ACTION_RECURSIVE 0x02 // deep through dircetory structure
#define FSYS_ACTION_USERECYCLEBIN 0x04 // move to recycle bin
#define FSYS_ACTION_MOVE 0x08 // delete after copy (=> move)
#define FSYS_ACTION_CONTINUE 0x10 // continue on error
#define FSYS_ACTION_KEEP_EXISTING 0x20 // do not overwrite objects in
>From the header, and any code paths that go with them too.
It'd be great to drop that big block of cruft :-)
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
