https://bugs.freedesktop.org/show_bug.cgi?id=52461
Markus Mohrhard <markus.mohrh...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |markus.mohrhard@googlemail.
| |com
--- Comment #7 from Markus Mohrhard <markus.mohrh...@googlemail.com> ---
Let me take over the mentoring for this one from Kendy.
The solution is actually quite simple.
Use a map in ScRangeFindList for maEntries like std::map<ScRange,
ScRangeFindData> and storing the color in ScRangeFindData. This also removes
the need for the static function ScRangeFindList::GetColorName. Now your insert
method does two things(actually std::map::insert will do the work for you):
If the range is already in the map return the old color otherwise insert and
return the new color.
Bonus points for cleaning up gridwin4.cxx:794 and following.
Follow-up easy hack if interested could be to make
ScInputHandler::InitRangeFinder use one of the existing formula parsers and go
through the formula tokens instead of implementing our n-th formula parser.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
