https://bugs.freedesktop.org/show_bug.cgi?id=42543

Lionel Elie Mamane <lio...@mamane.lu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|libreoffice-b...@lists.free |lio...@mamane.lu
                   |desktop.org                 |

--- Comment #20 from Lionel Elie Mamane <lio...@mamane.lu> 2012-01-30 08:37:28 
PST ---
I don't get the CommandType::TABLE vs CommandType::QUERY problem, so probably
that's an orthogonal problem.

In the case CommandType::TABLE, we have:

            if ( bDoEscapeProcessing )
            {
                Reference< XNameAccess > xTables( impl_getTables_throw() );
                if ( xTables->hasByName(m_aCommand) )
                {
                }
                else

This empty block there is very suspicious. It contained stuff, which was
commented out in

commit d4d5d883ecbc6e04cd28bb49be4c85f560a1bc48
Author: Ocke Janssen [oj] <ocke.jans...@sun.com>
Commit: Noel Power <noel.po...@novell.com>
Date:   Fri Jan 22 08:14:22 2010 +0100

    dba33f: #i108548# extend SingleSelectQueryComposer appendFilterByColumn
with additonal parameter


The commented out code itself was removed in

commit 910a1f688b21fb8104f756b108b90836840f70db
Author: Rubén Jáñez <rjanez...@gmail.com>
Commit: Ocke Janssen [oj] <ocke.jans...@sun.com>
Date:   Mon Oct 11 10:39:25 2010 +0100

    Removes some bogus comments found in Base.


My hunch is that we just have to add that code again. Testing that now.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to