https://bugs.freedesktop.org/show_bug.cgi?id=77206

Christian Lohmaier <lohma...@gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris.sherloc...@gmail.com,
                   |                            |lohma...@gmx.de,
                   |                            |nthieb...@gmail.com
                URL|                            |http://cgit.freedesktop.org
                   |                            |/libreoffice/core/commit/?i
                   |                            |d=143c059ff7f69a363b3cf736a
                   |                            |9f0197a9f25cf9c

--- Comment #10 from Christian Lohmaier <lohma...@gmx.de> ---
http://cgit.freedesktop.org/libreoffice/core/commit/?id=143c059ff7f69a363b3cf736a9f0197a9f25cf9c
is the very likely culprit

It crashes in mpGraphics->ReleaseFonts() in vcl/source/gdi/print.cxx - as the
comment above that line states:

#ifndef UNX
    // HACK to fix an urgent P1 printing issue fast
    // WinSalPrinter does not respect GetGraphics/ReleaseGraphics conventions
    // so Printer::mpGraphics often points to a dead WinSalGraphics
    // TODO: fix WinSalPrinter's GetGraphics/ReleaseGraphics handling
    mpGraphics->ReleaseFonts();
#endif


the above mentioned patch changed the handling, as before the patch the
mpGraphics->ReleaseFonts(); call was guarded by the "hack-block" like this:

#ifndef UNX
    // HACK to fix an urgent P1 printing issue fast
    // WinSalPrinter does not respect GetGraphics/ReleaseGraphics conventions
    // so Printer::mpGraphics often points to a dead WinSalGraphics
    // TODO: fix WinSalPrinter's GetGraphics/ReleaseGraphics handling
    if( meOutDevType != OUTDEV_PRINTER )
#endif
        mpGraphics->ReleaseFonts();

i.e. the patch removed the if statement, probably in error.

If I restore the if again (and put the ReleaseFonts call outside of the
ifndef), then no crash on windows...

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to