https://bugs.freedesktop.org/show_bug.cgi?id=40575

--- Comment #13 from Eike Rathke <er...@redhat.com> ---
@Julien:
No objection in general, but bear in mind that the Date::nDate value is stored
in a decimal coded way to hold YYYYMMDD so the maximum year value in a
sal_Int32 would be 214748 (0x7fffffff is 2147483647 not 4294967295 ;-)  As the
maximum number of normalized days must be representable by that coded
sal_Int32, the resulting MAX_DAYS would be 78383020 (214748*365), do not drop
those checks. Instead, verify that they do sane things, i.e. some currently set
9999-12-31 in such a case. Places may also check for year values of 9999 or
9957 or some such, introduce a DATE_MAX_YEAR constant for the 214748 maximum
year value and eliminate those hard coded values.

Furthermore not all code may be able to cope with a year value of more than 4
digits, either in input or display formats, field lengths, ... so there may be
some follow-up work to be done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to