https://bugs.documentfoundation.org/show_bug.cgi?id=91001
Maxim Monastirsky <momonas...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |momonas...@gmail.com
--- Comment #5 from Maxim Monastirsky <momonas...@gmail.com> ---
(In reply to Matthew Francis from comment #4)
> commit 5b32d9c4406a68507ac9737ee0ada8bd1d424815
> Author: navin patidar <pati...@kacst.edu.sa>
> Date: Wed Feb 27 08:25:45 2013 +0300
>
> fix fdo#61492: update sd:View with FONTHEIGHT attribute changes.
>
> update sd:View with FONTHEIGHT attribute changes, so that
> it can position bullet and text properly.
This approach seems a bit strange to me, because it sets the same text
attributes for a second time, just to properly position the bullet in the
preview mode (to be clear - the attributes that passed to sd::View are also
forwarded to EditView\EditEngine at some point). Also the assumption that you
can simply copy attributes to a new SfxItemSet and feed the View with it,
doesn't seem to work as soon as the selected text has several font sizes
(that's another regression from this commit), or when it has an empty bullet
item like in this bug. The flickering mentioned in the bug description, is most
probably because it sets the new (correct) size, but then immediately reverts
it by the second attributes setting I mentioned above.
Up to this stage, I managed to get 2 different working patches, and I'm not
sure which one is better (or maybe both approaches are wrong)?
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
