https://bugs.documentfoundation.org/show_bug.cgi?id=94557

--- Comment #11 from Julien Nabet <serval2...@yahoo.fr> ---
Lionel: I understand I should revert partly
http://cgit.freedesktop.org/libreoffice/core/commit/?id=76f33f10309b0ee384a75a7a854858b068d60495
to have this:
pComboBox->EnableAutocomplete( n != 0, false );
instead of this:
pComboBox->EnableAutocomplete( n != 0, true );
in both cases.

Then
http://opengrok.libreoffice.org/xref/core/vcl/source/control/ilstbox.cxx#263 is
obviously wrong:
    263         if ( bLazy  )
    264         {
    265             bMatch = rI18nHelper.MatchString( rStr, pImplEntry->maStr
);
    266         }
    267         else
    268         {
    269             bMatch = rStr.isEmpty() ||
(pImplEntry->maStr.startsWith(rStr));
    270         }
If changing this part, I suppose we should change the default value here:
sal_Int32           FindMatchingEntry( const OUString& rStr, sal_Int32  nStart
= 0, bool bForward = true, bool bLazy = true ) const;
http://opengrok.libreoffice.org/xref/core/vcl/inc/ilstbox.hxx#119

There something I don't understand about the method you quoted :
treatment is almost the same for m_isMatchCase = true or false, except in one
case bLazy value. But bLazy is not related to m_isMatchCase?
Or perhaps should we add isMatchCase parameter to FindMatchingEntry?

Quite confusing...

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to