https://bugs.documentfoundation.org/show_bug.cgi?id=96413

--- Comment #9 from Julien Nabet <serval2...@yahoo.fr> ---
Created attachment 121619
  --> https://bugs.documentfoundation.org/attachment.cgi?id=121619&action=edit
bt with debug symbols

After some tests with gdb, it seems it decides to escape or not from here:
http://opengrok.libreoffice.org/xref/core/tools/source/fsys/urlobj.cxx#541

    541 inline bool mustEncode(sal_uInt32 nUTF32, INetURLObject::Part ePart)
    542 {
    543     return !rtl::isAscii(nUTF32) || !(aMustEncodeMap[nUTF32] & ePart);
    544 }
(gdb indicates ePart=INetURLObject::PART_PCHAR)

which gives then:
http://opengrok.libreoffice.org/xref/core/tools/source/fsys/urlobj.cxx#441
a 128 elements array.

If I apply this patch:
diff --git a/tools/source/fsys/urlobj.cxx b/tools/source/fsys/urlobj.cxx
index 771c3bb..bf279f16f 100644
--- a/tools/source/fsys/urlobj.cxx
+++ b/tools/source/fsys/urlobj.cxx
@@ -442,7 +442,7 @@ static sal_uInt32 const aMustEncodeMap[128]
     = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
         0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
 /*   */                                              PP,
-/* ! */ PA   +PD+PE+PF+PG+PH+PI+PJ+PK+PL+PM+PN+PO+PP+PQ+PR,
+/* ! */ PA   +PD+PE+PF+PG+PH+PI+PJ+PK   +PM+PN+PO+PP+PQ+PR,
 /* " */                                  PM+PN   +PP,
 /* # */                                  PM,
 /* $ */ PA   +PD+PE+PF+PG+PH+PI+PJ+PK+PL+PM+PN+PO+PP+PQ+PR,

"!" is escaped.
However, I don't know the impact of this change on other parts of LO.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to