https://bugs.documentfoundation.org/show_bug.cgi?id=96888
--- Comment #33 from Dipankar Niranjan <dipankar1...@gmail.com> --- Hi, > > In /core/vcl/source/window/winproc.cxx > > In line 2001 before commit: > > if ( pSVEvent->mbCall && !pSVEvent->maDelData.IsDead() ) > > I do not know how to remove usage of pSVEvent->maDelData.IsDead() > > Oh ? so - what was associated with the maDelData ? - it rather depends on > that really =) so I think we need to look at all of the calls that did an > ImplAddDel on that member - and make sure we're checking them. > > > pSVEvent->mpWindow and pSVEvent->mpInstanceRef both fail to build. > > Oh ? why ? surely pSVEvent->mpWindow->IsDisposed() would work nicely. pSVEvent->mpWindow->IsDisposed() doesn't build and the vcl_timer test fails. We get a segmentation fault. Running Valgrind gives:http://pastebin.com/HPqeGN0t Also, I'm pretty sure we haven't called ImplAddDel on maDelData anywhere as can be seen from grok. So how do I proceed with this? I don't think we've initialized or allocated mem for mpWindowImpl which IsDisposed checks.. > > Provided these patches are correct, I would need some help with: > > 1)Line 413 of window2.cxx as it involves inheritance if I'm not wrong. > > Wow - that is horrible ! =) wow ... why do we bother casting to sal_uIntPtr > there. So - in this case we need to update the methods to instead of using > this awful sal_uIntPtr - instead passing a VclPtr<> around for the > mpFocusWindow. Then we can rip out the ImplFocusDelData struct: another nice > cleanup ! =) This cleanup may take a little bit of time too.. By mpFocusWindow, I think you meant mpFocusWin And should a new struct be created exclusively for mpFocusWin as we intend to remove ImplFocusDelData which presently contains mpFocusWin? Else, how do you propose to use mpFocusWin? -- You are receiving this mail because: You are the assignee for the bug.
_______________________________________________ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
