https://bugs.documentfoundation.org/show_bug.cgi?id=99093

--- Comment #9 from Markus Mohrhard <markus.mohrh...@googlemail.com> ---
(In reply to Tor Lillqvist from comment #6)
> Thanks Igor, that means that also moggi's fix for the column wrap-around
> case causes a similar problem then. Whew, I am not alone;)

Interestingly mso-dumper reports what we expect:

01BEh: =====================================================================
01BEh: DV - Data Validation Criteria (01BEh)
01BEh:   size = 43
01BEh: ---------------------------------------------------------------------
01BEh: 01 01 5C 00 01 00 00 00 01 00 00 00 01 00 00 00   ..\.............
01BEh: 01 00 00 00 05 00 00 00 4C 00 00 FF C0 00 00 FF   ........L.......
01BEh: FF 01 00 04 00 04 00 03 00 03 00                  ...........
01BEh: ---------------------------------------------------------------------
01BEh: type: whole number (0x1)
01BEh: error style: stop icon (0x0)
01BEh: list of valid inputs: no
01BEh: allow blank: yes
01BEh: suppress down-down in cell: no
01BEh: IME mode: No Control (0x0)
01BEh: show input message: yes
01BEh: show error message: yes
01BEh: operator type: Less Than (0x5)
01BEh: formula 1 (bytes): 4C 00 00 FF C0
01BEh: formula 1 (displayed): (single-ref: col=255[rel],row=0[rel])
01BEh: formula 2 (bytes): 
01BEh: formula 2 (displayed): 
01BEh: range: $D$5:$D$5


So basically we still have a wrap around case but I think we missed the wrap
around the other side case. In the code here we have a 4 + 255 = 259; if we now
calculate this mod 256 we get the expected result of 3.

I'll fix both commits and a add a set of tests for these conditions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to