https://bugs.documentfoundation.org/show_bug.cgi?id=99326
--- Comment #7 from Simon Long <si...@raspberrypi.org> ---
(In reply to Yousuf (Jay) Philips from comment #6)
> (In reply to Simon Long from comment #4)
> > In the GTK+2 case, auto-hiding should not always be disabled; it should be
> > disabled conditionally depending on the setting in the GTK+2 theme file
> > currently in effect for auto-hiding accelerators.
>
> Yes ideally it shouldnt always be disabled, but with the current state of UX
> issues that have arisen by following the condition in the gtk+2 theme file,
> it would be best to disable it when building against gtk2.
No, it wouldn't - that is a short-term bodge which does the wrong thing.
> > One of the differences between GTK+2 and GTK+3 is that in GTK+2, accelerator
> > auto-hide was controlled by the theme; in GTK+3 this option was removed and
> > the default became auto-hide enabled, with no option to disable it.
> >
> > The relevant theme variable in the GTK+2 theme file is "gtk-auto-mnemonics =
> > n" where n is 1 to enable auto-hide and 0 to disable it. If behaviour is to
> > be changed for GTK+2, it should respect this setting.
>
> Thanks for the information, though i dont know where to go to change this
> setting and their isnt a GUI for changing this setting that the novice user
> would know how to find. It is true that this is a setting in Gtk+2, but that
> doesnt mean that we must follow it, as there are other gtk+2 apps that dont
> - e.g. Firefox.
Novice users do not change this setting; theme authors do. All a novice user
does is to choose a theme. Theme authors do know where to find this setting,
and all applications which use GTK+2 properly obey it - the argument that
because some other applications are doing things incorrectly that it is
therefore ok for LO to also do things incorrectly is not really sound
reasoning.
Implementing code to read this value from the theme and thereupon to enable or
disable auto-hiding is a trivial change; it's probably easier than working out
how to conditionally build without any of the auto-hide code...
If I get time in the next few weeks I will look at adding the ability to read
this value from the theme and to use it to enable or disable auto-hide.
Incidentally - you mention above the ability to compile LO against gtk2 - is
that even possible? From what I could see when I was modifying the code, the
GTK theming implementation in VCL is purely to emulate GTK+3, not GTK+2. As
above, in *all* GTK+3 applications, accelerators are *always* autohidden - the
ability to toggle this behaviour is only relevant if you are trying to make VCL
look like a GTK+2 application which obeys a GTK+2 theme, and from what I could
see, LO doesn't do that at all.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
