https://bugs.documentfoundation.org/show_bug.cgi?id=89307

--- Comment #6 from Stephan Bergmann <sberg...@redhat.com> ---
The problematic operator is the (non-explicit) conversion operator

>    operator T *()    const { return pObj; }

not the dereference operator

>    T & operator *()  const { assert(pObj != nullptr); return *pObj; }

All uses of the former operator, and the operator itself, shall be removed. 
(There is no benefit in keeping it around defined as deleted.  But it can be
useful to temporarily define it as deleted, to find places that use this
conversion operator.)

Replacing uses of the latter operator with get() is of no benefit.  (But
removing the address-of operator

>    T * operator &()  const { return pObj; }

would be beneficial, as an overloaded address-of operator can be confusing.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to