https://bugs.documentfoundation.org/show_bug.cgi?id=100782

--- Comment #3 from Katarina Behrens (CIB) <katarina.behr...@cib.de> ---
Well, I already outlined something in my initial comment, if it ain't enough,
here are some more details

First off, in XPropertyList class (include/svx/xtable.hxx) change
XPropertyEntryList_impl typedef to a vector of std::unique_ptrs to
XPropertyEntry (instead of raw XPropertyEntry* pointers)

Then, you have to adapt XPropertyEntry::Insert, ::Remove, ::Replace etc.
methods (from svx/source/xoutdev/xtable.cxx) to operate on smart pointers
instead of raw pointers (you'll need to use reset(), get() etc. and make sure
you preserve the semantics of operations when doing so)

Now of course the code using those methods will not compile, which makes it
easy to find it (there's lot of users ot XPropertyList and derivatives in
cui/source/tabpages, but elsewhere too). Change this code to use the new
Insert, Remove, Replace etc. smart pointer-aware methods (that means in most of
the cases getting rid of manual delete calls and doing some more tweaks, if
applicable). 

Repeat until all the code compiles and all the unit tests pass

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to