https://bugs.documentfoundation.org/show_bug.cgi?id=104023

            Bug ID: 104023
           Summary: track changes - show changes is always marked as
                    enabled, even after disabling
           Product: LibreOffice
           Version: 5.3.0.0.alpha0+
          Hardware: All
                OS: All
            Status: UNCONFIRMED
          Severity: major
          Priority: medium
         Component: Writer
          Assignee: libreoffice-bugs@lists.freedesktop.org
          Reporter: jl...@mail.com

Description:
Edit - Track changes - Show Changes ALWAYS has a check-box in it.  Clicking on
Show changes does turn off showing changes, but cannot turn it back on.

Regression in 5.3 development branch.  Tested using Linux daily dbgutil
narrowed it down to around Sept 8 and then I identified the regression as
author  Noel Grandin <n...@peralex.com> 2016-09-07 11:10:40 (GMT)
commit  847e004e65ec3c35acff607588d15cd75a84f121
   convert nsRedlineMode_t to typed_flags

because these two lines are not equivalent:
-                bSet = (eMode & nMask) == nMask;
+                bSet = bool(eMode & nMask);

attachment 114078 can be used as a test document.  It already has Show Changes
enabled, with green changes showing.  Turning Show Changes off DOES turn off
the green marking, but the checkbox still indicates that Show Changes is
active, and clicking on it again does not shown the green changes again.

Steps to Reproduce:
1. Edit Menu - track changes - show changes is marked as enabled. click on it.


Actual Results:  
go back and it is still marked as enabled.

Expected Results:
On a new document - show changes should not even be enabled.  Clicking on it
should have marked it as disabled anyways.


Reproducible: Always

User Profile Reset: No

Additional Info:
Major severity - an important feature is completely disabled.


User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:49.0) Gecko/20100101
Firefox/49.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to