https://bugs.documentfoundation.org/show_bug.cgi?id=104986

--- Comment #11 from Lionel Elie Mamane <lio...@mamane.lu> ---
(In reply to Tor Lillqvist from comment #10)
> Suggested fix in https://gerrit.libreoffice.org/#/c/47271/

This change teaches the corresponding keywords to the LibreOffice SQL lexer.
The problem described here is that the *Firebird* embedded in LibreOffice
refuses these SQL commands (when they are passed bypassing the LibreOffice
parser), which is why we were talking about "maybe upgrading Firebird will fix
this". As such, I think it is unrelated to this bug seen strictly.

Teaching these keywords to the LibreOffice SQL lexer is useful, since this will
allow them to be used in SQL queries that are parsed by LibreOffice (if/when
they are supported by the underlying DBMS engine). This will preemptively solve
the bug that will immediately be filed after this bug is corrected, namely
"doesn't work in LibreOffice-parsed queries". LibreOffice-parser queries unlock
several features, like graphical editing of the query, choosing a sort order in
the GUI, etc). But we'll also have to put the new tokens in the relevant parser
nodes. I'm not sure out of a quick glance if that's non_second_datetime_field
(so that it is available in all of datetime_field), or only more specific uses
like extract_field. It depends whether these new keywords are valid interval
qualifiers or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to