https://bugs.documentfoundation.org/show_bug.cgi?id=115315

--- Comment #17 from Maxim Monastirsky <momonas...@gmail.com> ---
(In reply to Michael Meeks from comment #11)
> except the mbFrame thing is really not so clear to
> me as to its purpose as distinct from having valid mpFrameData
mbFrame means _this_ vcl::Window is a frame, while a valid mpFrameData only
means that the current vcl::Window presents in the hierarchy of some other
frame window, typically some control inside that window. This can be clearly
seen at the top of Window::ImplInsertWindow:

if ( pParent && !mpWindowImpl->mbFrame )
{
    // search frame window and set window frame data
    vcl::Window* pFrameParent = pParent->mpWindowImpl->mpFrameWindow;
    mpWindowImpl->mpFrameData     = pFrameParent->mpWindowImpl->mpFrameData;

so mpFrameData is just a pointer to the mpFrameData of the parent frame window. 

So:

> It is hard to think how not calling ImplAsyncFocusHdl on a disposed window
> is going to make life better generally for anything.
ImplAsyncFocusHdl isn't necessarily called on the window we're disposing.
Consider the scenario: A child control is disposed, and because of the missing
mpWindowImpl->mbFrame check it clears the focus event of the (not disposed!)
top level frame...

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs

Reply via email to