https://bugs.documentfoundation.org/show_bug.cgi?id=105368
Buovjaga <todven...@suomi24.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|bibisectRequest |bibisected, bisected
CC| |armin.le.gr...@me.com
OS|Windows (All) |All
--- Comment #7 from Buovjaga <todven...@suomi24.fi> ---
Bisected to
https://cgit.freedesktop.org/libreoffice/core/commit/?id=23391fdb5cffb62006415ad1f4c96b6ed5d50cf8
Adding Armin to CC. Test file coming next.
commit 23391fdb5cffb62006415ad1f4c96b6ed5d50cf8 (patch)
tree fc25a363096c6ed5d6aa1c58a7bfbdf4ca6d415a
parent 7e2ea27e5d56f5cf767a6718a0f5edc28e24af14 (diff)
tdf#98646 Fixed freeze by flattening loops
DrawViewShell::MakeVisible was using loops for finding the area
to change the visible part of the EditView to. That could (and did)
potentially loop for a long time for very large objects, deep zoom or
numerical problems. That loops were flattened, the results checked
to be the same.
Also added a test for numerical overflow for getting values from the
Rectangle describing the object size. Despite these values being
the result of erraneous import, I opt for checking and avoiding using
these values.
Change-Id: I783dc1f2ad9b6a60a47e660b0d576ea3f22a4e42
Reviewed-on: https://gerrit.libreoffice.org/23278
Also repro on Linux
Arch Linux 64-bit
Version: 6.1.0.0.alpha1+
Build ID: 21b11273ae91f0cf7fd5f3f9fd2168e4349852c4
CPU threads: 8; OS: Linux 4.16; UI render: default; VCL: kde4;
Locale: fi-FI (fi_FI.UTF-8); Calc: group
Built on May 11th 2018
--
You are receiving this mail because:
You are the assignee for the bug._______________________________________________
Libreoffice-bugs mailing list
Libreoffice-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
